[feat] Add Support for input_number domain #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding bug: Rounding error when input_number step is set to certain values (observed easily with step set to 2 or 3)
… result of both the step and the max of an input_number entity. Appears that at this time applyStep() is unnecessary, and was in fact causing the problem I have tested stepped sliders of both input_number entities as well as light and climate entities, and stepping still works as expected when applyStep() is not called at all. This does not resolve the issue where step count results in "illegal" values on certain input_number entities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new branch and PR since I can't fix the merge conflicts on @lizsugar's original PR (#7). Rebases their branch on top of mainline and then includes includes a doc update.
Closes #33