add vitest #4982
Merged
add vitest #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5933bad The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* migrate text jest tests to vitest * migrate heading jest tests to vitest * migrate textfield jest tests to vitest * migrate VideoPlayer jest tests to vitest and interactive stories * remove test for pauseplay, replaced with stories * replace GenericNotification jest tests to interaction stories * convert MenuTriggerProvider from jest to vitest * convert DateInputWithIconButton from jest to vitest * moved TitleBlockZen survey status tests to storybook * lint fix * remove flaky snapshots * fix flaky notification play test * intro timeout to wait for animation * fix lint * intro timeout to wait for animation * intro borders around the video player to showcase aspectratio * exclude the pauseplay story from chromatic * exclude thee genericnotification interaction story from chromatic * Update packages/components/src/Illustration/subcomponents/VideoPlayer/VideoPlayer.stories.tsx * fix videoplayer stickersheet * update generic notification to a story * Update packages/components/src/Illustration/subcomponents/VideoPlayer/VideoPlayer.spec.tsx Co-authored-by: Cassandra <[email protected]> --------- Co-authored-by: Geoffrey Chong <[email protected]> Co-authored-by: Cassandra <[email protected]>
…aizen-design-system into KZN-2614-new-jest-to-vitest
…aizen-design-system into KZN-2614-new-jest-to-vitest
mcwinter07
reviewed
Sep 2, 2024
HeartSquared
reviewed
Sep 2, 2024
packages/components/src/RichTextEditor/utils/commands/fixtures/helpers.ts
Show resolved
Hide resolved
HeartSquared
reviewed
Sep 2, 2024
HeartSquared
reviewed
Sep 2, 2024
| ), | ||
| }, | ||
| test: { | ||
| // TODO: Remove this when @HeartSquared fixes icons |
There was a problem hiding this comment.
Hahaha whaaaat 😂 I don't think we'd be removing the script until we actually delete the old icon, so it would still be relevant here
There was a problem hiding this comment.
lul, doxed in code comments 😆
HeartSquared
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Jest bad, vitest good
What
Everything changed