Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KZN-2614-jest-to-vitest #4971

Closed
wants to merge 63 commits into from
Closed

KZN-2614-jest-to-vitest #4971

wants to merge 63 commits into from

Conversation

gyfchong
Copy link
Contributor

@gyfchong gyfchong commented Aug 26, 2024

Why

Jest bad, vitest good

What

Everything changed

Notes

  • Tests that generally rely on classname matching are also left to jest as vitest's class name resolution is the final hashed CSS modules version, which makes it hard to target. So these will need to be rewritten to avoid

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 2644195

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gyfchong gyfchong marked this pull request as ready for review August 26, 2024 07:14
@gyfchong gyfchong requested a review from a team as a code owner August 26, 2024 07:14
@gyfchong gyfchong marked this pull request as ready for review August 28, 2024 03:18
@gyfchong gyfchong marked this pull request as draft August 28, 2024 06:22
@gyfchong gyfchong marked this pull request as ready for review August 29, 2024 02:33
@gyfchong gyfchong closed this Aug 29, 2024
@gyfchong
Copy link
Contributor Author

Moved to #4982

@gyfchong gyfchong deleted the KZN-2614-jest-to-vitest branch August 29, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant