Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] - Messages update / skeleton for refactoring #259

Merged
merged 18 commits into from
Jul 24, 2024
Merged

[Ruby] - Messages update / skeleton for refactoring #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
38b5515
Bump max messages version
luke-hill Jul 18, 2024
819db42
New changelog update
luke-hill Jul 18, 2024
9741cbf
Fix ref to ID Generator
luke-hill Jul 18, 2024
e1f91d4
Fix up reference to initialize having wrong ref to idgenerator
luke-hill Jul 18, 2024
81dfd49
Fix up razor template
luke-hill Jul 18, 2024
796efb2
Minor tidy of rakefile and remove capture warnings
luke-hill Jul 18, 2024
9fb8251
Rubocop TODO and warning about excessive refactoring yet!
luke-hill Jul 18, 2024
4c9772c
Fix gherkin bin file
luke-hill Jul 18, 2024
d8cd4b5
Tidy up ruby gemspec and set minimum version to 3.0
luke-hill Jul 18, 2024
4904bc1
Fix the generation of TODO to pass through correct ruby version
luke-hill Jul 18, 2024
6dd183f
Release using v3.3
luke-hill Jul 18, 2024
92ead71
Alter test matrix to remove invalid rubies and test on newer rubies
luke-hill Jul 18, 2024
087dfaf
Set minimum messages requirement in gherkin owing to new bin path for…
luke-hill Jul 18, 2024
1d58d52
Use spec_helper
luke-hill Jul 18, 2024
10a6a69
Tidy up query spec
luke-hill Jul 18, 2024
4bf43a8
Remove legacy ref for rake
luke-hill Jul 18, 2024
31bba30
Remove travis refs
luke-hill Jul 18, 2024
c102860
Add changelog
luke-hill Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-rubygem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2'
ruby-version: '3.3'
bundler-cache: true
- uses: cucumber/[email protected]
with:
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/test-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ jobs:
matrix:
os:
- ubuntu-latest
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
include:
- os: macos-latest
ruby: '3.2'
ruby: '3.3'

steps:
- uses: actions/checkout@v4
Expand All @@ -38,9 +38,7 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
working-directory: ruby

- run: bundle exec rake
working-directory: ruby

- run: make acceptance
working-directory: ruby
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
## [Unreleased]
### Added
- (i18n) Added Gujarati translation for "Rule" ([#249](https://github.com/cucumber/gherkin/pull/249))
- [Ruby] Skeleton to begin technical refactor of internals ([#259](https://github.com/cucumber/gherkin/pull/259))

### Fixed
- [.NET] Provide informative exception for trailing escapes in tables ([#245](https://github.com/cucumber/gherkin/pull/245))
Expand All @@ -20,6 +21,10 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- (i18n) Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))
- Intermittent failure of cpp test jobs in CI ([#217](https://github.com/cucumber/gherkin/issues/217))

### Changed
- [Java, JavaScript, PHP, Go, Ruby] Upgraded messages to v25
Copy link
Contributor Author

@luke-hill luke-hill Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check this is true. I just copied the previous changelog entry. Maybe we can get some script or something to update all language versions to update latest support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on my list to fix renovatebot/renovate#10616 properly. Then we'll have updates for Ruby again.

- [Ruby] Update minimum ruby requirement from 2.5 to 3.0 ([#259](https://github.com/cucumber/gherkin/pull/259))

## [28.0.0] - 2024-02-15
### Added
- [Python] Added release workflow for releasing to Pypi ([#213](https://github.com/cucumber/gherkin/pull/213))
Expand All @@ -30,7 +35,6 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- [Python] Reuse the action cucumber/action-publish-pypi in release ([#220](https://github.com/cucumber/gherkin/pull/220))
- [Python] Removed duplicate code in markdown token matcher ([#205](https://github.com/cucumber/gherkin/pull/205))
- [Java, JavaScript, PHP, Go, Ruby] Upgraded messages to v24
- Upgraded messages to v22

## [27.0.0] - 2023-09-15
### Added
Expand Down
1 change: 1 addition & 0 deletions ruby/.rspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
--require spec_helper
--color
13 changes: 13 additions & 0 deletions ruby/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
inherit_from: .rubocop_todo.yml

inherit_mode:
merge:
- Exclude

AllCops:
NewCops: disable
# Keep this inline with the lowest ruby version in the gemspec
TargetRubyVersion: 3.0
# Display cop name / style guide references
DisplayCopNames: true
DisplayStyleGuide: true
Loading
Loading