Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] - Messages update / skeleton for refactoring #259

Merged
merged 18 commits into from
Jul 24, 2024

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Update dependencies to support latest messages
Add in boilerplate to begin to refactor "some" parts of codebase

⚡️ What's your motivation?

Keep things updated and lean

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@@ -20,6 +20,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
- (i18n) Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))
- Intermittent failure of cpp test jobs in CI ([#217](https://github.com/cucumber/gherkin/issues/217))

### Changed
- [Java, JavaScript, PHP, Go, Ruby] Upgraded messages to v25
Copy link
Contributor Author

@luke-hill luke-hill Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check this is true. I just copied the previous changelog entry. Maybe we can get some script or something to update all language versions to update latest support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on my list to fix renovatebot/renovate#10616 properly. Then we'll have updates for Ruby again.

@luke-hill luke-hill merged commit 5061942 into main Jul 24, 2024
31 checks passed
@luke-hill luke-hill deleted the refactor/dep_update branch July 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants