Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nil checks on person deleted field #502

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Added nil checks on person deleted field #502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8a2d1b
Added nil checks on person deleted field
droberts-ctrlo Dec 18, 2024
a82392d
Modified nil check on deleted field
droberts-ctrlo Dec 19, 2024
f5804da
Changed to more sensible condition check rather than ternary operator
droberts-ctrlo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/GADS/Datum/Person.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ use Log::Report 'linkspace';
use Moo;
use MooX::Types::MooseLike::Base qw/:all/;
use namespace::clean;
use GADS::DateTime;

extends 'GADS::Datum';

with 'GADS::Role::Presentation::Datum::Person';
with 'GADS::DateTime';

after set_value => sub {
my ($self, $value, %options) = @_;
Expand Down Expand Up @@ -379,7 +379,7 @@ sub _build_for_code
team => $_->{team},
title => $_->{title},
text => $_->{value},
deleted => GADS::DateTime::parse_datetime($_->{deleted})->epoch,
deleted => $_->{deleted} && GADS::DateTime::parse_datetime($_->{deleted})->epoch,
}
} @{$self->value_hash};

Expand Down
Loading