Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nil checks on person deleted field #502

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Added nil checks on person deleted field #502

merged 3 commits into from
Dec 19, 2024

Conversation

droberts-ctrlo
Copy link
Contributor

No description provided.

abeverley
abeverley reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@abeverley abeverley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave. I think better to do a check on $_->{deleted} being null, otherwise you're calling parse_datetime twice.

@abeverley abeverley merged commit 6838fdd into ctrlo:dev Dec 19, 2024
6 checks passed
@droberts-ctrlo droberts-ctrlo deleted the test-fix branch December 19, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeverley abeverley abeverley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droberts-ctrlo @abeverley