Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make function non mandatory in ctfd_challenge #133

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Make function non mandatory in ctfd_challenge #133

merged 1 commit into from
Dec 13, 2024

Conversation

pandatix
Copy link
Member

Closes #132.

It does not affect the API in HCL, and improve the checks on standard OR dynamic challenge attributes.

@pandatix pandatix added enhancement New feature or request go Pull requests that update Go code labels Dec 12, 2024
@pandatix pandatix requested a review from NicoFgrx December 12, 2024 10:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12294629590

Details

  • 30 of 44 (68.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 70.033%
Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/challenge_resource.go 25 39 64.1%
Totals Coverage Status
Change from base Build 12144207231: -0.1%
Covered Lines: 1470
Relevant Lines: 2099
💛 - Coveralls

@pandatix pandatix mentioned this pull request Dec 12, 2024
Open
NicoFgrx
NicoFgrx approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@NicoFgrx NicoFgrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pandatix pandatix merged commit aa02466 into main Dec 13, 2024
6 checks passed
@pandatix pandatix deleted the fix/challenge-function branch December 13, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoFgrx NicoFgrx NicoFgrx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard challenges does not work
3 participants
@pandatix @coveralls @NicoFgrx