Split ctfd_challenge
in two separate resources
#134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #133, this PR would introduce breaking changes.
The reflection behind it comes from #131.
Inside this PR I drop
ctfd_challenge
in favor of 2 new resources:ctfd_challenge_standard
ctfd_challenge_dynamic
Additionally to the features discussed in the issue (TL;DR better documentation, maintainability, and autocompletion), the internals changed toward a better fit of the CTFd API, and ease development of other providers for plugins.
For instance, when conceiving the Terraform provider for the
ctfd-chall-manager
plugin we would be able to reuse theChallengeStandardResourceModel
structure andChallengeStandardResourceAttributes
variable, in the way I implemented thectfd_challenge_dynamic
.Reusing the ID for other resources (e.g.
ctfd_file
,ctfd_flag
) is still possible.Poke @Nishacid. I know you used it for GreHack24, your feedback on such an evolution would be welcome 😄