-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: can't support prevrando opcode #499
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #499 +/- ##
===========================================
- Coverage 61.55% 61.54% -0.01%
===========================================
Files 128 128
Lines 9496 9500 +4
===========================================
+ Hits 5845 5847 +2
- Misses 3111 3112 +1
- Partials 540 541 +1
|
|
||
time := ctx.BlockHeader().Time | ||
blockTime := uint64(time.Unix()) | ||
blockNumber := big.NewInt(ctx.BlockHeight()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applications already mix a bunch of different factors to emulate randomness, I don't think we should emulate it, and the emulation won't be secure , until we have a real random oracle
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)