Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: can't support prevrando opcode #499

Closed
wants to merge 4 commits into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 17, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang July 17, 2024 01:32
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.54%. Comparing base (d874df7) to head (6a1c8c4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #499      +/-   ##
===========================================
- Coverage    61.55%   61.54%   -0.01%     
===========================================
  Files          128      128              
  Lines         9496     9500       +4     
===========================================
+ Hits          5845     5847       +2     
- Misses        3111     3112       +1     
- Partials       540      541       +1     
Files Coverage Δ
x/evm/keeper/config.go 91.17% <75.00%> (-2.58%) ⬇️


time := ctx.BlockHeader().Time
blockTime := uint64(time.Unix())
blockNumber := big.NewInt(ctx.BlockHeight())
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems block time might differ between abci and grpc call

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applications already mix a bunch of different factors to emulate randomness, I don't think we should emulate it, and the emulation won't be secure , until we have a real random oracle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants