Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: block header not aligned with latest height in checkState #579

Closed

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jul 17, 2024

use finalize state block header when CreateQueryContext with latest height and checkState block header height is fall behind

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

use prepare or process proposal state block header when CreateQueryContext
with latest height and checkState block header height is fall behind
@mmsqe mmsqe requested a review from yihuang July 18, 2024 06:35
@yihuang
Copy link
Collaborator

yihuang commented Jul 20, 2024

is it upstream issue, or it's introduced by our changes?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Jul 21, 2024

is it upstream issue, or it's introduced by our changes?

should be same in main since lastBlockHeight bump when commit before header change in checkState, I saw mismatch when set larger total like 1k

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Aug 21, 2024
@github-actions github-actions bot closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants