Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(topology): update for new GraphQL schema #1224

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 5, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Based on #1222
Depends on cryostatio/cryostat#315

Description of the change:

Adjustments for updated GraphQL schema in Cryostat 3.0.

Motivation for the change:

This re-enables the Topology view and all its features.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores
Copy link
Member Author

Ready for re-review @aali309 @mwangggg

src/app/utils/fakeData.ts Outdated Show resolved Hide resolved
@mwangggg
Copy link
Member

the tests for AllTargetsArchivedRecordingsTable and AutomatedAnalysisCard still use the old schema: https://github.com/andrewazores/cryostat-web/blob/daa01bcf769bd0b733887f95a5ef05fc81a9c84e/src/test/Archives/AllTargetsArchivedRecordingsTable.test.tsx#L75-L85

@aali309
Copy link
Contributor

aali309 commented Mar 15, 2024

This PR looks good to me. Topology and Archive all work as expected.

@andrewazores andrewazores merged commit 4765ac6 into cryostatio:cryostat3-graphql Mar 15, 2024
16 checks passed
@andrewazores andrewazores deleted the cryostat3-graphql-topology branch March 15, 2024 15:38
Copy link

mergify bot commented Mar 15, 2024

⚠️ The sha of the head commit of this PR conflicts with #1227. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants