Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Archived recordings tables improperly react to "Recording Saved" notifications #441

Closed
andrewazores opened this issue May 6, 2024 · 2 comments · Fixed by #485
Closed
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Current Behavior

When a "Recording Saved" notification is emitted, the Archived recordings tables (at least Recordings > Archived and Archives > All Archives) update with a new entry. However, the recording name added to the table is the name of the source active recording, not the new archived recording filename, and the file size field is undefined/NaN.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

image

@andrewazores andrewazores added the bug Something isn't working label May 6, 2024
@andrewazores
Copy link
Member Author

@andrewazores
Copy link
Member Author

andrewazores commented May 8, 2024

To test:

  1. run smoketest
  2. create the automated rule below
  3. go to Recordings > select the localhost:0 target > go to Archived tab
  4. wait some time for the automated rule to begin creating archived recordings and notifications to appear
{
  "id": 1,
  "name": "test",
  "description": "",
  "matchExpression": "target.connectUrl.contains('localhost:0')",
  "eventSpecifier": "template=Profiling,type=TARGET",
  "archivalPeriodSeconds": 10,
  "initialDelaySeconds": 0,
  "preservedArchives": 3,
  "maxAgeSeconds": 300,
  "maxSizeBytes": 0,
  "enabled": true
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants