Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingpin/v2 #389

Merged
merged 3 commits into from
May 30, 2024
Merged

Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingpin/v2 #389

merged 3 commits into from
May 30, 2024

Conversation

gravufo
Copy link
Contributor

@gravufo gravufo commented Apr 19, 2024

Description of your changes

Fixes #388

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

None, this should have no impact, it is essentially the same module reference.

@gravufo gravufo changed the title Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingp… Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingpin/v2 Apr 19, 2024
@gravufo gravufo mentioned this pull request Apr 19, 2024
Merged
2 tasks
@gravufo gravufo force-pushed the replace-kingpin-v2 branch from b3a3b01 to 8a02a1c Compare May 16, 2024 02:38
@gravufo gravufo mentioned this pull request May 16, 2024
Closed
@ulucinar
Copy link
Collaborator

Hi @gravufo,
Could you please run go mod tidy and commit the changes? Thank you very much in advance.

@gravufo gravufo force-pushed the replace-kingpin-v2 branch from 8a02a1c to 14ac95f Compare May 30, 2024 11:18
@gravufo
Copy link
Contributor Author

gravufo commented May 30, 2024

@ulucinar done! Let me know if there is anything else :)

ulucinar
ulucinar approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gravufo, lgtm.

@ulucinar ulucinar merged commit 4073347 into crossplane:main May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar ulucinar approved these changes

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

@mergenci mergenci Awaiting requested review from mergenci mergenci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consumers are "forced" to use gopkg.in/alecthomas/kingpin.v2
2 participants
@gravufo @ulucinar