Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingpin/v2 #714

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

gravufo
Copy link
Contributor

@gravufo gravufo commented Apr 19, 2024

Description of your changes

Fixes #713

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

None, this should have no impact, it is essentially the same module reference.

A successful uptest run of Subnet.network: https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/9383114181

Note

Need to get crossplane/crossplane-tools#63 and crossplane/upjet#389 merged before merging this one, so that we can remove the temporary replace directives.

@turkenf
Copy link
Collaborator

turkenf commented May 6, 2024

/test-examples="examples/network/subnet.yaml"

go.mod Outdated Show resolved Hide resolved
@gravufo gravufo force-pushed the replace-kingpin-v2 branch from 1d0f19c to 49548ee Compare May 30, 2024 21:09
@turkenf
Copy link
Collaborator

turkenf commented May 31, 2024

/test-examples="examples/network/subnet.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 31, 2024

@gravufo, please ignore the failed uptest run, caused due to the wrong path. But it seems that there are uncommitted changes. Please run make generate and commit all changes.

@gravufo gravufo force-pushed the replace-kingpin-v2 branch from 6876d7c to 3a6efde Compare May 31, 2024 22:31
Signed-off-by: Christian Artin <[email protected]>
@gravufo
Copy link
Contributor Author

gravufo commented Jun 1, 2024

@gravufo, please ignore the failed uptest run, caused due to the wrong path. But it seems that there are uncommitted changes. Please run make generate and commit all changes.

Done. I didn't realize I would need to run that command since I was just changing things in place, but it seems like the upgrade of upjet had an impact on the resources.

Let's hope this time is the right one :)

PS: I gave rights to maintainers to edit my branch, so if necessary don't hesitate to edit it!

Thanks

@gravufo gravufo requested a review from turkenf June 1, 2024 01:40
Signed-off-by: Christian Artin <[email protected]>
@gravufo
Copy link
Contributor Author

gravufo commented Jun 3, 2024

@turkenf I fixed the go fmt error, apparently I had to run go fmt on the hack/main.go.tmpl file so that it applies to all generated resources.
Should be good to merge now!

@turkenf
Copy link
Collaborator

turkenf commented Jun 5, 2024

/test-examples="examples/network/v1beta2/subnet.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your effort in this PR @gravufo 🙌

@turkenf turkenf merged commit 0a511b8 into crossplane-contrib:main Jun 5, 2024
12 checks passed
@gravufo gravufo deleted the replace-kingpin-v2 branch June 5, 2024 14:27
@gravufo gravufo restored the replace-kingpin-v2 branch June 5, 2024 14:27
@gravufo gravufo deleted the replace-kingpin-v2 branch June 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumers are "forced" to use gopkg.in/alecthomas/kingpin.v2
2 participants