-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace gopkg.in/alecthomas/kingpin.v2 by github.com/alecthomas/kingpin/v2 #714
Conversation
/test-examples="examples/network/subnet.yaml" |
31db2b9
to
1d0f19c
Compare
1d0f19c
to
49548ee
Compare
/test-examples="examples/network/subnet.yaml" |
@gravufo, please ignore the failed uptest run, caused due to the wrong path. But it seems that there are uncommitted changes. Please run |
…in/v2 Signed-off-by: Christian Artin <[email protected]>
Signed-off-by: Christian Artin <[email protected]>
6876d7c
to
3a6efde
Compare
Signed-off-by: Christian Artin <[email protected]>
Done. I didn't realize I would need to run that command since I was just changing things in place, but it seems like the upgrade of upjet had an impact on the resources. Let's hope this time is the right one :) PS: I gave rights to maintainers to edit my branch, so if necessary don't hesitate to edit it! Thanks |
Signed-off-by: Christian Artin <[email protected]>
@turkenf I fixed the |
/test-examples="examples/network/v1beta2/subnet.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your effort in this PR @gravufo 🙌
Description of your changes
Fixes #713
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
None, this should have no impact, it is essentially the same module reference.
A successful uptest run of
Subnet.network
: https://github.com/crossplane-contrib/provider-upjet-azure/actions/runs/9383114181Note
Need to get crossplane/crossplane-tools#63 and crossplane/upjet#389 merged before merging this one, so that we can remove the temporary replace directives.