-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Terraform provider version to v5.50.0 #1315
Conversation
/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml" |
1 similar comment
/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml" |
/test-examples="examples/cloud9/v1beta1/environmentec2.yaml" |
/test-examples="examples/fsx/v1beta1/ontapfilesystem.yaml" |
/test-examples="examples/memorydb/v1beta1/user.yaml" |
8940e5f
to
dc3e2c8
Compare
/test-examples="examples/memorydb/v1beta1/user.yaml" |
/test-examples="examples/fsx/v1beta1/ontapfilesystem.yaml" |
/test-examples="examples/cloud9/v1beta1/environmentec2.yaml" |
/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml" |
/test-examples="examples/dms/v1beta1/eventsubscription-without-source-id.yaml" |
/test-examples="examples/rds/v1beta1/clusterroleassociation.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ulucinar, LGTM.
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
the dependency consumed in the Terraform provider. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
…unexported Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar LGTM!
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ulucinar 🙏 Updates to controllers puzzled me, yet they seem unharmful.
Description of your changes
Fixes #1317
Depends on: upbound/terraform-provider-aws#243
This PR bumps the Terraform provider version to v5.50.0 and the Go version to
1.22
as the underlying provider uses Go version.We need to make sure that the
ClusterAuth.eks
resource is functional as we also update the aws-sdk-v2 version to match the version consumed in the Terraform provider (relevant issue: #1248).Thanks to @mbbush for the PR to upgrade Terraform provider. The commit with ID aca95c9 was cherry-picked, we appreciate his efforts in increasing our automated testing coverage 🙌
I have:
make reviewable
to ensure this PR is ready for review.ClusterAuth.eks
: Unpin theaws-sdk-go-v2
dependency #1317Addedbackport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Breaking CRD OpenAPI v3 schema changes
package/crds/cloud9.aws.upbound.io_environmentec2s.yaml
Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206624705
package/crds/dms.aws.upbound.io_eventsubscriptions.yaml
Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9207519365
package/crds/fsx.aws.upbound.io_ontapfilesystems.yaml
Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206624036
package/crds/memorydb.aws.upbound.io_users.yaml
Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206623035
Native schema version changes
aws_secretsmanager_secret_rotation
Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206625332