Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider version to v5.50.0 #1315

Merged
merged 8 commits into from
May 23, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented May 21, 2024

Description of your changes

Fixes #1317
Depends on: upbound/terraform-provider-aws#243

This PR bumps the Terraform provider version to v5.50.0 and the Go version to 1.22 as the underlying provider uses Go version.

We need to make sure that the ClusterAuth.eks resource is functional as we also update the aws-sdk-v2 version to match the version consumed in the Terraform provider (relevant issue: #1248).

Thanks to @mbbush for the PR to upgrade Terraform provider. The commit with ID aca95c9 was cherry-picked, we appreciate his efforts in increasing our automated testing coverage 🙌

I have:

How has this code been tested

Breaking CRD OpenAPI v3 schema changes

  1. package/crds/cloud9.aws.upbound.io_environmentec2s.yaml
    Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206624705
  2. package/crds/dms.aws.upbound.io_eventsubscriptions.yaml
    Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9207519365
  3. package/crds/fsx.aws.upbound.io_ontapfilesystems.yaml
    Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206624036
  4. package/crds/memorydb.aws.upbound.io_users.yaml
    Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9206623035

Native schema version changes

@ulucinar ulucinar marked this pull request as draft May 21, 2024 14:58
@turkenf
Copy link
Collaborator

turkenf commented May 21, 2024

/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml"

1 similar comment
@turkenf
Copy link
Collaborator

turkenf commented May 21, 2024

/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 21, 2024

/test-examples="examples/cloud9/v1beta1/environmentec2.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 21, 2024

/test-examples="examples/fsx/v1beta1/ontapfilesystem.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 21, 2024

/test-examples="examples/memorydb/v1beta1/user.yaml"

@ulucinar ulucinar force-pushed the bump-tf-5.50.0 branch 2 times, most recently from 8940e5f to dc3e2c8 Compare May 23, 2024 10:04
@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/memorydb/v1beta1/user.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/fsx/v1beta1/ontapfilesystem.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/cloud9/v1beta1/environmentec2.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/secretsmanager/v1beta1/secretrotation.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/dms/v1beta1/eventsubscription-without-source-id.yaml"

@turkenf
Copy link
Collaborator

turkenf commented May 23, 2024

/test-examples="examples/rds/v1beta1/clusterroleassociation.yaml"

@turkenf turkenf marked this pull request as ready for review May 23, 2024 14:01
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ulucinar, LGTM.

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar mentioned this pull request May 23, 2024
3 tasks
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar 🙏 Updates to controllers puzzled me, yet they seem unharmful.

@ulucinar ulucinar merged commit e71d951 into crossplane-contrib:main May 23, 2024
11 checks passed
@ulucinar ulucinar deleted the bump-tf-5.50.0 branch May 23, 2024 14:54
@turkenf turkenf mentioned this pull request May 24, 2024
54 tasks
@ulucinar ulucinar mentioned this pull request May 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin the aws-sdk-go-v2 dependency
5 participants