Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin the aws-sdk-go-v2 dependency #1317

Closed
ulucinar opened this issue May 22, 2024 · 1 comment · Fixed by #1315
Closed

Unpin the aws-sdk-go-v2 dependency #1317

ulucinar opened this issue May 22, 2024 · 1 comment · Fixed by #1315
Assignees
Labels
enhancement New feature or request

Comments

@ulucinar
Copy link
Collaborator

ulucinar commented May 22, 2024

What problem are you facing?

We've pinned the aws-sdk-go-v2 dependency to resolve an issue with a quick workaround. However, we will need to update this dependency at a point in time and we need to address the underlying issue by changing how we use the AWS Go SDK to fetch the EKS cluster credentials.

We need to verify the ClusterAuth.eks functionality before merging #1315.

This issue also demonstrates the extra maintenance burden on us when we implement resources using the AWS Go SDK.

How could Official AWS Provider help solve your problem?

Let's find out how we should now fetch the credentials using the AWS Go SDK and remove the pin.

@ulucinar ulucinar added enhancement New feature or request needs:triage labels May 22, 2024
@sergenyalcin sergenyalcin self-assigned this May 22, 2024
@ulucinar ulucinar self-assigned this May 23, 2024
@ulucinar
Copy link
Collaborator Author

I've done the following tests with #1315 and can confirm that the kubeconfigs prepared by the ClusterAuth.eks resource are still functional when we bump the aws-sdk-go-v2 dependency to v1.26.2. I've verified this using the following authentication configurations:

  • IAM role long-term access keys
  • IRSA configuration with a two-hop role chaining

Looks like it's safe to continue with #1315.

@sergenyalcin sergenyalcin removed their assignment May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants