Improve exception handling: Properly raise IntegrityError exceptions
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/error-handling-integrity-error
branch
from
8c39426
to
c4fb76b
Compare
matriv
approved these changes
Sep 28, 2023
|
Apologies, accidentally I approved already, instead of only comment. |
amotl
force-pushed
the
amo/error-handling-integrity-error
branch
from
c4fb76b
to
6717def
Compare
|
Thanks. I've just amended the patch to provide a corresponding test case. |
... when receiving `DuplicateKeyException` errors from CrateDB, instead of the more general `ProgrammingError`.
amotl
force-pushed
the
amo/error-handling-integrity-error
branch
from
6717def
to
ea2555c
Compare
2 tasks
matriv
approved these changes
Sep 28, 2023
This was referenced Oct 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
When receiving
DuplicateKeyExceptionerrors from CrateDB, SQLAlchemy should raise correspondingIntegrityErrorexceptions instead ofProgrammingError, because applications expect it this way.Details
This patch evaluates the area preliminarily, mainly whether it will work by using CrateDB's own variants of the canonical DBAPI exceptions, and whether SQLAlchemy will honor that properly.
References
IntegrityError, butProgrammingErroris raised sqlalchemy-cratedb#96