You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At crate/mlflow-cratedb#9, we discovered that the CrateDB SQLAlchemy dialect raises a ProgrammingError exception when the server raises a DuplicateKeyException. However, SQLAlchemy-based applications seem to expect the IntegrityError exception type instead, see sqlalchemy_store.py.
Details
mlflow-cratedb has a monkeypatch, which augments the _raise_for_status function to emit an IntegrityError correspondingly.
Proposal
Add this to the code base, untangled from the monkeypatch, together with an accompanying test case, if not present.
The text was updated successfully, but these errors were encountered:
About
At crate/mlflow-cratedb#9, we discovered that the CrateDB SQLAlchemy dialect raises a
ProgrammingError
exception when the server raises aDuplicateKeyException
. However, SQLAlchemy-based applications seem to expect theIntegrityError
exception type instead, see sqlalchemy_store.py.Details
mlflow-cratedb has a monkeypatch, which augments the
_raise_for_status
function to emit anIntegrityError
correspondingly.Proposal
Add this to the code base, untangled from the monkeypatch, together with an accompanying test case, if not present.
The text was updated successfully, but these errors were encountered: