-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiled content pipeline bugfixes & new fields #841
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
using Microsoft.Xna.Framework; | ||
using MonoGame.Extended.Collisions.Layers; | ||
using MonoGame.Extended.Collisions.QuadTree; | ||
using Newtonsoft.Json.Linq; | ||
|
||
namespace MonoGame.Extended.Collisions | ||
{ | ||
|
@@ -97,6 +98,50 @@ public override void Update(GameTime gameTime) | |
} | ||
} | ||
|
||
/// <summary> | ||
/// Cast an actor's colliders in a direction and check for collisions. | ||
/// </summary> | ||
/// <param name="actors">The list of actor colliders to cast.</param> | ||
/// <param name="move">Normalized vector representing the direction to cast each shape.</param> | ||
/// <param name="hitBuffer">Buffer to receive results.</param> | ||
/// <param name="distance">Maximum distance over which to cast the Collider(s).</param> | ||
public int Cast(IEnumerable<ICollisionActor> actors, Vector2 move, List<CollisionEventArgs> hitBuffer, float distance) | ||
{ | ||
hitBuffer.Clear(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it matter that hitBuffer.Clear() isn't called in the 2nd Cast? What if someone calls the 2nd public method instead, then the hitBuffer won't get cleared right? |
||
Vector2 offset = move.NormalizedCopy() * distance; | ||
return Cast(actors, offset, hitBuffer); | ||
} | ||
|
||
|
||
/// <summary> | ||
/// Cast an actor's colliders in a direction and check for collisions. | ||
/// </summary> | ||
/// <param name="actors">The list of actor colliders to cast.</param> | ||
/// <param name="offset">Vector representing the translation to use for each cast.</param> | ||
/// <param name="hitBuffer">Buffer to receive results.</param> | ||
public int Cast(IEnumerable<ICollisionActor> actors, Vector2 offset, List<CollisionEventArgs> hitBuffer) | ||
{ | ||
foreach (ICollisionActor actor in actors) | ||
{ | ||
try | ||
{ | ||
actor.Bounds.Position += offset; | ||
foreach ((_, Layer secondLayer) in _layerCollision) | ||
{ | ||
if (!secondLayer.Space.Contains(actor)) continue; | ||
foreach (ICollisionActor other in secondLayer.Space.Query(actor.Bounds.BoundingRectangle)) | ||
if (actor != other && actor.Bounds.Intersects(other.Bounds)) | ||
{ | ||
CollisionEventArgs collisionInfo = new() { Other = other, PenetrationVector = CalculatePenetrationVector(actor.Bounds, other.Bounds) }; | ||
hitBuffer.Add(collisionInfo); | ||
} | ||
} | ||
} | ||
finally { actor.Bounds.Position -= offset; } | ||
} | ||
return hitBuffer.Count; | ||
} | ||
|
||
/// <summary> | ||
/// Inserts the target into the collision tree. | ||
/// The target will have its OnCollision called when collisions occur. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,26 +4,20 @@ public class TiledMapPropertyValue | |
{ | ||
public string Value { get; } | ||
|
||
public TiledMapProperties Properties; | ||
public string Type { get; } | ||
|
||
public TiledMapPropertyValue() | ||
{ | ||
Value = string.Empty; | ||
Properties = new(); | ||
} | ||
public string PropertyType { get; } | ||
|
||
public TiledMapPropertyValue(string value) | ||
public TiledMapProperties Properties; | ||
|
||
public TiledMapPropertyValue(string value, string type, string propertyType) | ||
{ | ||
Value = value; | ||
Type = type; | ||
PropertyType = propertyType; | ||
Properties = new(); | ||
} | ||
|
||
public TiledMapPropertyValue(TiledMapProperties properties) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this removed for a reason? |
||
{ | ||
Value = string.Empty; | ||
Properties = properties; | ||
} | ||
|
||
public override string ToString() => Value; | ||
|
||
//public static implicit operator TiledMapPropertyValue(string value) => new(value); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MonoGame.Extended trying to stay AOT compliant?
This article on MonoGame says that Newtonsoft json are not AOT compliant for console? Also that Linq should be avoided? Also, why Newtonsoft's Linq vs System.Linq?
https://docs.monogame.net/articles/preparing_for_consoles.html