tiled content pipeline bugfixes & new fields #841
Conversation
added support for reading type field & repeatX/repeatY from Tiled image layers (renderer still does not support this) property value read bugfix Til;edMapProperties.cs:10
this is a Cast function in CollisionComponent that ICollisionActor objects can use (not unlike the one that rigidbodies get in unity)
|
Hi @KatDevsGames , Your timing is absolutely impeccable. The RepeatX and RepeatY for the image layer in tiled is actually something I started looking into last night when trying to implement a parallax image layer for my project. Do you have any idea on how to approach this in regard to the renderer? Please let me know if I can be of any assistance. I am not exactly sure how to approach it, but wouldn't mind helping tackle that if it is something that proves difficult.
|
|
Hi @KatDevsGames and @tigurx ! I have watched PR.
In future, please, make PR separately by theme. |
|
@Gandifil , For RepeatX & RepeatY -- Yes, it just repeats the image N times along the respected axis like you suggested. 2024-04-28.15-58-35.mp4 |
There was a problem hiding this comment.
Looks like Cast is added but not yet used. I see the bug fix. I see you also added 4 properties (type, propertyType, repeatX, repeatY).
I noticed you removed a constructor for TiledMapPropertyValue that used to allow passing in a TiledMapProperties instance. Was this intended?
| /// <param name="distance">Maximum distance over which to cast the Collider(s).</param> | ||
| public int Cast(IEnumerable<ICollisionActor> actors, Vector2 move, List<CollisionEventArgs> hitBuffer, float distance) | ||
| { | ||
| hitBuffer.Clear(); |
There was a problem hiding this comment.
Does it matter that hitBuffer.Clear() isn't called in the 2nd Cast? What if someone calls the 2nd public method instead, then the hitBuffer won't get cleared right?
| @@ -6,6 +6,7 @@ | |||
| using Microsoft.Xna.Framework; | |||
| using MonoGame.Extended.Collisions.Layers; | |||
| using MonoGame.Extended.Collisions.QuadTree; | |||
| using Newtonsoft.Json.Linq; | |||
There was a problem hiding this comment.
Is MonoGame.Extended trying to stay AOT compliant?
This article on MonoGame says that Newtonsoft json are not AOT compliant for console? Also that Linq should be avoided? Also, why Newtonsoft's Linq vs System.Linq?
https://docs.monogame.net/articles/preparing_for_consoles.html
| Properties = new(); | ||
| } | ||
|
|
||
| public TiledMapPropertyValue(TiledMapProperties properties) |
There was a problem hiding this comment.
Was this removed for a reason?
added support for reading type field from TiledMapPropertyContent (Tiled lets you set it...)
added support for repeatX/repeatY fields from Tiled image layers property (renderer still does not support this yet)
value read bugfix @TiledMapProperties.cs:10 - this got introduced when you pulled my previous pr (sorry)