chore(x/tx): Harmonize TypeResolver interface #16846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
commented
Jul 5, 2023
| @@ -31,13 +31,16 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## v0.9.0 | |||
There was a problem hiding this comment.
I'll be tagging v0.9.0 of x/tx after this PR.
There was a problem hiding this comment.
Ah, I'll probably wait for this to be fixed before tagging: #16521 (comment) forgot about this.
likhita-809
reviewed
Jul 6, 2023
It is broken in another PR (see #16846 (comment)) |
tac0turtle
reviewed
Jul 10, 2023
| @@ -14,6 +14,11 @@ import ( | |||
| "cosmossdk.io/core/address" | |||
| ) | |||
|
|
|||
| type TypeResolver interface { | |||
There was a problem hiding this comment.
should we put this in core and import it everywhere so we dont have the same issue in the future
There was a problem hiding this comment.
I am uncertain if its worth adding an extra package in core for that. Not sure how we would even name it.
However, if you have a proposition, I am not against it.
tac0turtle
reviewed
Jul 10, 2023
tac0turtle
approved these changes
Jul 10, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
TypeResolverinterface is different inx/txthan in the rest of the codebase (orm and client/v2).cosmos-sdk/orm/model/ormtable/build.go
Lines 64 to 67 in c7270e8
cosmos-sdk/client/v2/autocli/flag/builder.go
Lines 15 to 18 in c7270e8
This PR harmonize it.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change