Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync main changelogs with v0.47.11, v0.50.6, modules and x/tx #20125

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Apr 22, 2024

Description

Add v0.47.11, v0.50.6, modules and x/tx changelogs


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced the wait-tx query command for enhanced transaction handling.
    • Added new query versions in the x/nft module for improved data retrieval.
  • Improvements

    • Enhanced telemetry conditions for better data collection and analysis.
    • Upgraded various dependencies across modules for improved performance and security.
  • Bug Fixes

    • Addressed issues in modules such as x/authz, x/feegrant, and others to enhance stability and functionality.
  • API Changes

    • Implemented API breaking changes in x/circuit and x/upgrade modules to align with new standards and dependencies.

@julienrbrt julienrbrt requested a review from a team as a code owner April 22, 2024 09:41
Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Warning

Rate Limit Exceeded

@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 2 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 7bc2afb and efead5e.

Walkthrough

Version v0.50.6 of the cosmos-sdk introduces several enhancements and bug fixes across multiple modules, including new features like the wait-tx query command, improvements in telemetry, dependency upgrades, and robust error handling in genesis operations. This update aims to increase stability, performance, and usability of the SDK.

Changes

Files Change Summaries
cosmos-sdk, x/authz, x/bank, x/nft, x/upgrade, x/gov Updated InitGenesis and ExportGenesis to return errors, upgraded dependencies, and introduced new features.
x/circuit, x/nft, x/upgrade API breaking changes, upgraded SDK version due to Prometheus changes, bumped cosmossdk.io/store to v1.1.0.
x/feegrant Module extraction, interface changes, dependency upgrades, and bug fixes.
x/tx Improved JSON attribute sorting in inline_json encoder.

Possibly related issues

  • cosmos/cosmos-sdk#16593: The issue requests documentation updates for version 0.50. The changelog indicates significant changes and new features in v0.50.6 that should be documented, aligning with the issue's objective to keep documentation current with the latest SDK version.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -33,6 +33,12 @@ Since v0.13.0, x/tx follows Cosmos SDK semver: https://github.com/cosmos/cosmos-

## [Unreleased]

## [v0.13.3](https://github.com/cosmos/cosmos-sdk/releases/tag/x/tx/v0.13.3) - 2024-04-22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO, tag x/tx once this is merged.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 11

Actionable comments outside the diff hunks (2)
x/feegrant/CHANGELOG.md (2)

Line range hint 59-59: Correct the grammatical errors.

- * [#18767](https://github.com/cosmos/cosmos-sdk/pull/18767) Ensure we only execute revokeAllowance if there is no error is the grant is to be removed.
+ * [#18767](https://github.com/cosmos/cosmos-sdk/pull/18767) Ensure we only execute revokeAllowance if there is no error and the grant is to be removed.

Line range hint 65-65: Correct the repeated word.

- * [#15347](https://github.com/cosmos/cosmos-sdk/pull/15347) `ValidateBasic` is treated as a no op now with with acceptance of RFC001
+ * [#15347](https://github.com/cosmos/cosmos-sdk/pull/15347) `ValidateBasic` is treated as a no-op now with acceptance of RFC001

x/upgrade/CHANGELOG.md Show resolved Hide resolved
x/upgrade/CHANGELOG.md Outdated Show resolved Hide resolved
x/feegrant/CHANGELOG.md Show resolved Hide resolved
x/feegrant/CHANGELOG.md Show resolved Hide resolved
x/feegrant/CHANGELOG.md Outdated Show resolved Hide resolved
x/nft/CHANGELOG.md Outdated Show resolved Hide resolved
x/evidence/CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 0aff4f2 Apr 22, 2024
53 checks passed
@julienrbrt julienrbrt deleted the julien/changelog-x-main branch April 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants