fix: x/tx/decode: fix (*Decoder).Decode crash with invalid length prefix #16681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches a panic from an invalid length prefix found by fuzzing. This change instead returns an error and a test. Fixes #16680
odeke-em
force-pushed
the
x-tx-decode-fix-decode.Decoder-crash-with-invalid-length-prefix
branch
from
16c2c17
to
63b9f0b
Compare
alexanderbez
approved these changes
Jun 26, 2023
tac0turtle
approved these changes
Jun 26, 2023
julienrbrt
approved these changes
Jun 26, 2023
julienrbrt
deleted the
x-tx-decode-fix-decode.Decoder-crash-with-invalid-length-prefix
branch
|
@kocubinski you had mentioned that we should backport this PR, and get it into "Eden" |
x/tx is a standalone go.mod that does not import the SDK, we tag it from main, so there is no need to backport. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches a panic from an invalid length prefix found by fuzzing. This change instead returns an error and a test.
Fixes #16680