Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: autocli go.mod and package naming #13294

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Sep 14, 2022

Description

Ref #11775

This moves:

  • github.com/cosmos/cosmos-sdk/client/v2 -> cosmossdk.io/client/v2 (we need vanity URL updates for this)
  • github.com/cosmos/cosmos-sdk/client/v2/cli -> cosmossdk.io/client/v2/autocli since autocli seems better

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review September 14, 2022 20:03
@aaronc aaronc requested a review from a team as a code owner September 14, 2022 20:03
@github-actions github-actions bot added the C:CLI label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #13294 (fb1a0a0) into main (8542288) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13294      +/-   ##
==========================================
+ Coverage   54.94%   55.00%   +0.05%     
==========================================
  Files         648      649       +1     
  Lines       55346    55404      +58     
==========================================
+ Hits        30411    30474      +63     
+ Misses      22491    22479      -12     
- Partials     2444     2451       +7     
Impacted Files Coverage Δ
client/v2/cli/query.go 86.20% <ø> (ø)
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
x/group/keeper/keeper.go 56.64% <0.00%> (+0.39%) ⬆️
x/distribution/simulation/operations.go 90.32% <0.00%> (+9.67%) ⬆️

@julienrbrt julienrbrt merged commit ae21d8c into main Sep 14, 2022
@julienrbrt julienrbrt deleted the aaronc/autocli-rename branch September 14, 2022 21:11
@aaronc aaronc mentioned this pull request Oct 13, 2022
19 tasks
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants