Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename autocli package #13547

Merged
merged 2 commits into from
Oct 14, 2022
Merged

refactor!: rename autocli package #13547

merged 2 commits into from
Oct 14, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Oct 13, 2022

Description

Seems like in #13294, I actually forgot to rename the package somehow.

This renames client/v2/cli -> client/v2/autocli.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Oct 13, 2022
@aaronc aaronc marked this pull request as ready for review October 13, 2022 21:36
@aaronc aaronc requested a review from a team as a code owner October 13, 2022 21:36
@aaronc aaronc enabled auto-merge (squash) October 13, 2022 21:40
@aaronc
Copy link
Member Author

aaronc commented Oct 13, 2022

I really have no idea why CLI is failing. It's not failing locally for me and I can't see anything useful in the github action logs.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #13547 (681e18d) into main (05d1138) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13547      +/-   ##
==========================================
+ Coverage   53.79%   53.90%   +0.11%     
==========================================
  Files         653      643      -10     
  Lines       56825    55464    -1361     
==========================================
- Hits        30569    29898     -671     
+ Misses      23813    23167     -646     
+ Partials     2443     2399      -44     
Impacted Files Coverage Δ
simapp/genesis_account.go
simapp/genesis.go
simapp/simd/cmd/root.go
simapp/state.go
simapp/export.go
simapp/test_helpers.go
simapp/upgrades.go
simapp/simd/cmd/genaccounts.go
simapp/simd/cmd/testnet.go
simapp/app.go
... and 1 more

@aaronc aaronc merged commit de49cb4 into main Oct 14, 2022
@aaronc aaronc deleted the aaronc/autocli-rename-pkg branch October 14, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants