Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect custom JSON unmarshaler logic in protobuf resource specs #491

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: respect custom JSON unmarshaler logic in protobuf resource specs #491

merged 1 commit into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. feat: respect custom JSON unmarshaler logic in protobuf resource specs 

    If a protobuf spec implements `json.Unmarshaler`, use that function to unmarshal it from JSON, as the default `protojson.UnmarshalOptions` ignores it.

Add a test for both JSON and YAML custom unmarshaling logic.

Co-authored-by: Artem Chernyshev <[email protected]>
Signed-off-by: Utku Ozdemir <[email protected]>
    @utkuozdemir @Unix4ever
    utkuozdemir and Unix4ever committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8911486 View commit details
    Browse the repository at this point in the history