feat: respect custom JSON unmarshaler logic in protobuf resource specs #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a protobuf spec implements `json.Unmarshaler`, use that function to unmarshal it from JSON, as the default `protojson.UnmarshalOptions` ignores it. Add a test for both JSON and YAML custom unmarshaling logic. Co-authored-by: Artem Chernyshev <[email protected]> Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
respect-custom-json-unmarshal
branch
from
2ef4774
to
8911486
Compare
Unix4ever
approved these changes
Sep 10, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a protobuf spec implements
json.Unmarshaler, use that function to unmarshal it from JSON, as the defaultprotojson.UnmarshalOptionsignores it.Add a test for both JSON and YAML custom unmarshaling logic.