build-deps.txt: add shellcheck #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI was updated[0] to use coreos-assembler as a buildroot instead of the fcos-buildroot container and the openshift/os `validate` job[1] fails because shellcheck isn't installed in coreos-assembler. It cannot be installed using `sudo` when running on OpenShift so it needs to be installed directly in coreos-assembler. [0] openshift/release@68a7999 [1] https://github.com/openshift/os/blob/ce4da959eb3fc9477a0a96b69e6efd084a69b9ac/ci/prow-entrypoint.sh#L162
jlebon
approved these changes
Nov 27, 2024
|
Just going to go ahead and merge this. All the relevant CIs went past the point where this change is relevant. So let's sprint to getting openshift/os CI working again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was updated[0] to use coreos-assembler as a buildroot instead of the fcos-buildroot container and the openshift/os
validatejob[1] fails because shellcheck isn't installed in coreos-assembler. It cannot be installed usingsudowhen running on OpenShift so it needs to be installed directly in coreos-assembler.[0] openshift/release@68a7999
[1] https://github.com/openshift/os/blob/ce4da959eb3fc9477a0a96b69e6efd084a69b9ac/ci/prow-entrypoint.sh#L162