Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: bump version to 4.19 #1654

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

mike-nguyen
Copy link
Member

4.18 branched so bump the versioni in main development to 4.19.

Note: CI hasn't been updated to use 9.6 repos yet.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@mike-nguyen mike-nguyen changed the title bump version to 4.19 NO-JIRA: bump version to 4.19 Nov 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request explicitly references no jira issue.

In response to this:

4.18 branched so bump the versioni in main development to 4.19.

Note: CI hasn't been updated to use 9.6 repos yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mike-nguyen mike-nguyen force-pushed the 419_manifest branch 2 times, most recently from b8d0a22 to 2553d32 Compare November 27, 2024 03:28
@mike-nguyen
Copy link
Member Author

/test validate

@mike-nguyen
Copy link
Member Author

I think we have some fallout from openshift/release#59000 for the ci/prow/validate. Moving from fcos-buildroot to the cosa container, we lost shellcheck and unable to install it on the running container due to privileges.

@mike-nguyen
Copy link
Member Author

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@jlebon
Copy link
Member

jlebon commented Nov 27, 2024

Minor typo in commit message: s/versioni/version/

It'll take some time until cosa is rebuilt and propagates to the build cluster. I think the auto-retest here won't work because it needs to actually rebuild the image too. So we'll need /test images. But no point in doing that until we at least see the latest tag in https://quay.io/repository/coreos-assembler/coreos-assembler?tab=tags&tag=latest get bumped.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

6 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@jlebon
Copy link
Member

jlebon commented Nov 27, 2024

/test images
/test validate

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ce4da95 and 2 for PR HEAD 2553d32 in total

4.18 branched so bump the version in main development to 4.19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@mike-nguyen
Copy link
Member Author

Fixed the commit message but it removed the lgtm label.

@jlebon
Copy link
Member

jlebon commented Nov 27, 2024

/retest-required

@jlebon
Copy link
Member

jlebon commented Nov 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0c45f98 into openshift:master Nov 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants