Revert "mantle: use os.ReadDir for lightweight directory reading"
#3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c7fb302.
|
Looks like all the "newly failing tests because we now run all the tests" are going to have to be worked through before we merge this. Otherwise we're going to break CI in various places. One of the failures is openshift/os#1036 |
well actually that one isn't new because it's not a shared test. The other one is: |
travier
added a commit
to travier/os
that referenced
this pull request
Oct 27, 2022
This is temporary to let us land coreos/coreos-assembler#3137. See openshift#1041.
|
/test rhcos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3082
See #3135
I'm working on a fix for the underlying issue but revert this until it's ready.