Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCOS 4.12: ext.config.shared tests are not detected/run anymore #3135

Closed
travier opened this issue Oct 25, 2022 · 14 comments
Closed

RHCOS 4.12: ext.config.shared tests are not detected/run anymore #3135

travier opened this issue Oct 25, 2022 · 14 comments
Assignees
Labels
bug Something isn't working jira for syncing to jira

Comments

@travier
Copy link
Member

travier commented Oct 25, 2022

Bug Report

See openshift/os#1033.

Kola does not detect / run shared tests anymore:

$ cosa kola list | grep shared
empty
$ export COREOS_ASSEMBLER_CONTAINER=quay.io/coreos-assembler/coreos-assembler:rhcos-4.11
$ cosa kola list | grep shared
...
ext.config.shared.networking.resolv.systemd-resolved                            [all]                                                           [all]         [fcos]
ext.config.shared.podman.rootless-systemd                                       [qemu-unpriv]                                                   [all]         [all]
...

Environment

What operating system is being used to run coreos-assembler?

Fedora 36

What operating system is being assembled?

RHCOS

Is coreos-assembler running in Podman or Docker?

podman

If Podman, is coreos-assembler running privileged or unprivileged?

Privileged

@travier
Copy link
Member Author

travier commented Oct 25, 2022

Found issue in c7fb302 from #3082

@travier
Copy link
Member Author

travier commented Oct 25, 2022

Confirmed that reverting this commit brings back shared tests.

@travier
Copy link
Member Author

travier commented Oct 28, 2022

Reverted in #3137. I'm working on a re-revert with a fix.

@travier travier self-assigned this Oct 28, 2022
@travier travier added jira for syncing to jira bug Something isn't working labels Oct 28, 2022
@dustymabe
Copy link
Member

Reverted in #3137. I'm working on a re-revert with a fix.

@travier - any updates on ^^ ?

@travier
Copy link
Member Author

travier commented Nov 16, 2022

I had started working on it before going the revert route but it's a tricky code path and could not get a fix ready at the time. Will have to take a look again or let someone else pick it up.

travier added a commit to travier/coreos-assembler that referenced this issue Nov 16, 2022
@travier
Copy link
Member Author

travier commented Nov 16, 2022

Pushed my non-working draft in #3204

@travier travier removed their assignment Nov 16, 2022
@jbtrystram jbtrystram self-assigned this Aug 24, 2023
@jbtrystram
Copy link
Contributor

I am trying to investigate that but I can't reproduce the issue.
Since the change was reverted i expect to see the shared tests when building kola from main (3ac75dc):

[coreos-assembler]$ ./mantle/build kola
Building kola
[coreos-assembler]$ 
[coreos-assembler]$ ./bin/kola version
mantle/kola version 0.15.0+296-g3ac75dcf8
[coreos-assembler]$ ./bin/kola list | grep shared
empty

Is this is because i am using a different version of the cosa container ?

@travier
Copy link
Member Author

travier commented Aug 24, 2023

Where are you running kola? To see the shared tests, you need to run it in a the folder where you ran cosa init for openshift/os: https://github.com/openshift/os/blob/master/docs/development-scos.md

@travier
Copy link
Member Author

travier commented Aug 24, 2023

Hum, I can't get them either. Maybe we already regressed on this but this is weird.

@jbtrystram
Copy link
Contributor

Where are you running kola? To see the shared tests, you need to run it in a the folder where you ran cosa init for openshift/os: openshift/os@master/docs/development-scos.md

I was simply replicating what you posted in the initial issue above

@travier
Copy link
Member Author

travier commented Aug 24, 2023

Oh indeed. This is not explicitly written but the current directory for those commands was the folder you get after a cosa init.

@jbtrystram
Copy link
Contributor

Where are you running kola? To see the shared tests, you need to run it in a the folder where you ran cosa init for openshift/os: openshift/os@master/docs/development-scos.md

yeah I tried that, and did not get them, that's why I was confused and commented :)

@travier
Copy link
Member Author

travier commented Aug 24, 2023

With an image built (i.e. after a cosa fetch && cosa build), I get the ext.config.shared.* tests from cosa kola list | grep shared.

jbtrystram added a commit that referenced this issue Aug 28, 2023
Added a separate block to address symlinks loading.
It should work with nested symlinks, as it simply recurse calls with the
resolved path, but I have not tested it.

Fixes #3135
@jbtrystram
Copy link
Contributor

This was probably fixed in #3341
See #3585 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jira for syncing to jira
Projects
None yet
3 participants