Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20093: Use one crypto worker to read default master wrapping key tag #6029

Merged

Conversation

anien
Copy link
Contributor

@anien anien commented Apr 16, 2024

Retrieve default master wrapping key alias only in rekey bus processor.
Use IndividualKeyRotationRequest kafka message to pass the default master wrapping key alias to rewrap bus processor.

When retrieving the status of key rotation, show the default master wrapping key alias instead of the hardcoded 'master' value.

API PR: #1607
E2E tests PR: #588

@anien
Copy link
Contributor Author

anien commented Apr 16, 2024

build e2e

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Apr 16, 2024

Building E2E Tests on PR-6029

Build Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-rebuild-e2e-tests/job/PR-6029/3/

@corda-jenkins-ci02
Copy link
Contributor

Building E2E Tests on PR-6029

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Apr 16, 2024

Jenkins build for PR 6029 build 7

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1713801775808
Helm chart version produced by this PR: 5.3.0-alpha.1713801775808
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6029/corda
Helm chart Polaris score: 82

@anien
Copy link
Contributor Author

anien commented Apr 17, 2024

build e2e

@anien anien force-pushed the anna/CORE-20093-one-worker-reads-default-master-key branch from eef190b to ff2d20f Compare April 18, 2024 11:52
@anien anien marked this pull request as ready for review April 18, 2024 16:02
@anien anien requested review from a team as code owners April 18, 2024 16:02
@anien anien force-pushed the anna/CORE-20093-one-worker-reads-default-master-key branch from ff2d20f to f36cc3b Compare April 22, 2024 10:58
@bpaunescu bpaunescu self-requested a review April 22, 2024 14:51
bpaunescu
bpaunescu previously approved these changes Apr 22, 2024
Copy link
Contributor

@bpaunescu bpaunescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anien anien merged commit e1f86b5 into release/os/5.3 Apr 22, 2024
4 checks passed
@anien anien deleted the anna/CORE-20093-one-worker-reads-default-master-key branch April 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants