Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20093: Add default master wrapping key alias to individual key rotation request message #1607

Merged

Conversation

anien
Copy link
Contributor

@anien anien commented Apr 16, 2024

To improve the sync issues between crypto workers when updating the configuration before key rotation, we use only one place to retrieve the default master wrapping key alias. To pass it to other workers, we use kafka message.

Runtime-os PR: #6029

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Apr 16, 2024

Jenkins build for PR 1607 build 3

Build Successful:
Jar artifact version produced by this PR: 5.3.0.12-alpha-1713782925670

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1607/2/ has failed for PR 1607 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@anien anien marked this pull request as ready for review April 18, 2024 16:02
@anien anien requested a review from a team as a code owner April 18, 2024 16:02
@anien anien force-pushed the anna/CORE-20093-one-worker-reads-default-master-key branch from 87eaafe to 1889d76 Compare April 22, 2024 10:48
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@bpaunescu bpaunescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anien anien merged commit cdacba8 into release/os/5.3 Apr 22, 2024
5 checks passed
@anien anien deleted the anna/CORE-20093-one-worker-reads-default-master-key branch April 22, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants