Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cirrus: update CI images #24227

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 10, 2024

Images from containers/automation_images#387

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2024
@baude
Copy link
Member

baude commented Oct 10, 2024

LGTM

@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

unknown time zone EST

unknown time zone MST7MDT

Something is broken on debian, it seems it is missing certain timezones now?

@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

unknown time zone EST

unknown time zone MST7MDT

Something is broken on debian, it seems it is missing certain timezones now?

From the debian changelog:

  • Upstream obsoleted the System V names CET, CST6CDT, EET, EST*, HST, MET,
    MST*, PST8PDT, and WET. They are symlinks now. Move those zones to
    tzdata-legacy and update /etc/localtime on package update to the new names.
    Please use Etc/GMT* in case you want to avoid DST changes.

I guess I update the test here then and hope this is enough as this might hit fedora sooner or later too.

@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

@edsantiago PTAL

test/e2e/containers_conf_test.go Outdated Show resolved Hide resolved
In debian EST and MST7MDT are gone by default and moved to a special
package[1], instead of also installing that in the images lets use
different timezones in the test.

[1] https://salsa.debian.org/glibc-team/tzdata/-/commit/42c0008f86a5a53e1a37fefa93fdd3685313e86f

Signed-off-by: Paul Holzinger <[email protected]>
They no longer work in the latest image update, it is not clear why and
I do not have the time to debug that stuff. I opened containers#24230 to track it.

Signed-off-by: Paul Holzinger <[email protected]>
@edsantiago
Copy link
Member

"Adding fedoraproject.org to the local registry cache is too hard right now," he said. "We can worry about it some other day."

Sigh.

@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

"Adding fedoraproject.org to the local registry cache is too hard right now," he said. "We can worry about it some other day."

Sigh.

[+0557s] ok 264 [700] podman play --build --context-dir in 1845ms
...
[+0681s] # # test yaml:
[+0681s] #     apiVersion: v1
[+0681s] #     kind: Pod
[+0681s] #     metadata:
[+0681s] #       labels:
[+0681s] #         app: test
[+0681s] #       name: p-t265-jok99zot
[+0681s] #     spec:
[+0681s] #       containers:
[+0681s] #       - command:
[+0681s] #         - id
[+0681s] #         image: userimage-t265-jok99zot
[+0681s] #         name: c-t265-jok99zot
[+0681s] #         resources: {}
[+0681s] #     status: {}
[+0681s] #
[+0681s] # [16:27:56.449275187] # /var/tmp/go/src/github.com/containers/podman/bin/podman play kube --build --start=false /tmp/CI_1QV2/podman_bats.36TZHH/test.yaml
[+0681s] # [16:29:56.466603131] Resolving "userimage-t265-jok99zot" using unqualified-search registries (/etc/containers/registries.conf)
[+0681s] # Trying to pull docker.io/library/userimage-t265-jok99zot:latest...
[+0681s] # Trying to pull quay.io/userimage-t265-jok99zot:latest...
[+0681s] # Trying to pull registry.fedoraproject.org/userimage-t265-jok99zot:latest...
[+0681s] # time="2024-10-10T16:28:56Z" level=warning msg="Failed, retrying in 1s ... (1/3). Error: initializing source docker://registry.fedoraproject.org/userimage-t265-jok99zot:latest: pinging container registry registry.fedoraproject.org: Get \"https://registry.fedoraproject.org/v2/\": dial tcp 38.145.60.21:443: i/o timeout"
[+0681s] # timeout: sending signal TERM to command ‘/var/tmp/go/src/github.com/containers/podman/bin/podman’
[+0681s] # [16:29:56.471535522] [ rc=124 (** EXPECTED 125 **) ]

This seems unexpected, we should not resolve the short name there I think as this is a a custom image build there.

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Oct 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d512e44 into containers:main Oct 10, 2024
82 checks passed
@Luap99 Luap99 deleted the ci-image-update branch October 10, 2024 17:28
@edsantiago
Copy link
Member

This seems unexpected, we should not resolve the short name there I think as this is a a custom image build there.

I think shortname resolution is expected in this test:

    _write_test_yaml command=id image=$userimage    <<< if we didn't want shortname resolution, this would be qualified
    run_podman 125 play kube --build --start=false $TESTYAML
    assert "$output" "=~" \
        "Error: short-name resolution enforced but cannot prompt without a TTY|Resolving \"$userimage\" using unqualified-search registries" \
        "The error message does match any of the expected ones"

I will wipe this off my worry list unless/until I hear otherwise.

@Luap99
Copy link
Member Author

Luap99 commented Oct 11, 2024

If it causes flakes then it is a concern. Maybe not bad enough to fix immediately but I will start documenting them in https://issues.redhat.com/browse/RUN-2202 so we know what needs to be addressed to remove such network flakes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants