-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zstd on windows #387
Merged
Merged
Add zstd on windows #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have zstd by default so we need to install it. In particular I am looking at switching the repo archive to zstd as this makes things much faster (over 1min in podman)[1] but the windows testing is unable to extract that. While archiver added zstd support a while back it is not in the version that is on chocolatey which seems a bit out of date. [1] containers/podman#24120 Signed-off-by: Paul Holzinger <[email protected]>
Bump debian tar timebomb, remove manual crun install as the package is stable now and most importantly remove IMA workaround as the issue[1], we will see if that is true. [1] containers/podman#18543 Signed-off-by: Paul Holzinger <[email protected]>
Cirrus CI build successful. Found built image names and IDs:
|
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Oct 10, 2024
Images from containers/automation_images#387 Signed-off-by: Paul Holzinger <[email protected]>
|
Fingers crossed for the |
Images are being tested in containers/podman#24227 and containers/podman#24120 |
LGTM and is merged into Podman. @Luap99 should this be tagged for updating the rest of the repos? |
Yes sure let's give it go elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows: add zstandard package
Windows does not have zstd by default so we need to install it. In
particular I am looking at switching the repo archive to zstd as this
makes things much faster (over 1min in podman)[1] but the windows
testing is unable to extract that. While archiver added zstd support a
while back it is not in the version that is on chocolatey which seems a
bit out of date.
[1] containers/podman#24120
Build new images
Bump debian tar timebomb, remove manual crun install as the package is
stable now and most importantly remove IMA workaround as the issue[1],
we will see if that is true.
[1] containers/podman#18543