Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd on windows #387

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add zstd on windows #387

merged 2 commits into from
Oct 10, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Oct 10, 2024

windows: add zstandard package
Windows does not have zstd by default so we need to install it. In
particular I am looking at switching the repo archive to zstd as this
makes things much faster (over 1min in podman)[1] but the windows
testing is unable to extract that. While archiver added zstd support a
while back it is not in the version that is on chocolatey which seems a
bit out of date.

[1] containers/podman#24120

Build new images

Bump debian tar timebomb, remove manual crun install as the package is
stable now and most importantly remove IMA workaround as the issue[1],
we will see if that is true.

[1] containers/podman#18543

Windows does not have zstd by default so we need to install it. In
particular I am looking at switching the repo archive to zstd as this
makes things much faster (over 1min in podman)[1] but the windows
testing is unable to extract that. While archiver added zstd support a
while back it is not in the version that is on chocolatey which seems a
bit out of date.

[1] containers/podman#24120

Signed-off-by: Paul Holzinger <[email protected]>
Bump debian tar timebomb, remove manual crun install as the package is
stable now and most importantly remove IMA workaround as the issue[1],
we will see if that is true.

[1] containers/podman#18543

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 changed the title Win zstd Add zstd on windows Oct 10, 2024
Copy link

Cirrus CI build successful. Found built image names and IDs:

Stage Image Name IMAGE_SUFFIX
base debian do-not-use
base fedora do-not-use
base fedora-aws do-not-use
base fedora-aws-arm64 do-not-use
base image-builder do-not-use
base prior-fedora do-not-use
cache build-push c20241010t105554z-f40f39d13
cache debian c20241010t105554z-f40f39d13
cache fedora c20241010t105554z-f40f39d13
cache fedora-aws c20241010t105554z-f40f39d13
cache fedora-netavark c20241010t105554z-f40f39d13
cache fedora-netavark-aws-arm64 c20241010t105554z-f40f39d13
cache fedora-podman-aws-arm64 c20241010t105554z-f40f39d13
cache fedora-podman-py c20241010t105554z-f40f39d13
cache prior-fedora c20241010t105554z-f40f39d13
cache rawhide c20241010t105554z-f40f39d13
cache win-server-wsl c20241010t105554z-f40f39d13

Luap99 added a commit to Luap99/libpod that referenced this pull request Oct 10, 2024
@edsantiago
Copy link
Member

debian prior-fedora fedora fedora-aws rawhide
kernel 6.11.2-1 6.5.6-300 6.8.5-301 6.8.5-301 6.8.5-301
6.10.9-1 ⇑
grub2-common 2.12-5 2.06-121 2.06-123 2.06-123 2.12-7
2.12-4 ⇑
aardvark-dns 1.12.2-1 1.12.2-2 1.12.2-2 1.12.2-2 1.12.2-2
1.12.1-1 ⇑
buildah 1.37.3+ds1-3 1.37.1-1 1.37.4-1 1.37.3-1 1.37.4-1
1.37.2+ds1-3 ⇑ 1.37.1-1 ⇑ 1.37.1-1 ⇑ 1.37.2-1 ⇑
conmon 2.1.12-1 2.1.12-2 2.1.12-2 2.1.12-2 2.1.12-3
2.1.10+ds1-1+b1 ⇑ 2.1.12-1 ⇑ 2.1.12-2 ⇑
container-selinux ? 2.233.0-1 2.233.0-1 2.233.0-1 2.233.0-1
2.232.1-1 ⇑ 2.232.1-1 ⇑ 2.232.1-1 ⇑ 2.232.1-2 ⇑
containers-common ? 1-99 0.60.4-1 0.60.4-1 0.60.4-1
0.60.1-1 ⇑ 0.60.1-1 ⇑ 0.60.2-1 ⇑
criu 3.17.1-3 3.19-2 4.0-1 3.19-4 4.0-1
3.19-6 ⇑ 3.19-7 ⇑
docker-ce 5:27.3.1-1~debian.12~bookworm ? ? ? ?
5:27.2.1-1~debian.12~bookworm ⇑
golang 2:1.23~2 1.22.7-3 1.22.7-1 1.22.7-1 1.23.2-2
2:1.22~3 ⇑ 1.21.12-1 ⇑ 1.22.6-1 ⇑ 1.22.6-1 ⇑ 1.23.0-2 ⇑
gvisor-tap-vsock ? 0.7.5-1 ? ? ?
0.7.4-1 ⇑
passt 2024-09-06 2024-09-06 2024-09-06 2024-09-06 2024-09-06
2024-08-14 ⇑
podman 5.2.3+ds1-3 4.9.4-1 5.2.4-1 5.2.3-1 5.2.4-1
5.2.2+ds1-2 ⇑ 5.2.2-1 ⇑ 5.2.2-1 ⇑ 5.2.2-1 ⇑
runc 1.1.12+ds1-5+b1 1.1.12-1 1.1.12-3 1.1.12-3 1.1.12-4
1.1.12+ds1-5 ⇑
skopeo 1.16.1+ds1-1 1.16.1-1 1.16.1-1 1.16.1-1 1.16.1-2
1.13.3+ds1-2+b2 ⇑ 1.16.1-1 ⇑
systemd 256.7-1 254.18-1 255.12-1 255.12-1 256.5-1
256.6-1 ⇑ 254.16-1 ⇑ 255.10-3 ⇑ 255.10-3 ⇑

@edsantiago
Copy link
Member

Fingers crossed for the ima thing

Luap99 added a commit to Luap99/libpod that referenced this pull request Oct 10, 2024
@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

Images are being tested in containers/podman#24227 and containers/podman#24120

@edsantiago
Copy link
Member

LGTM and is merged into Podman.

@Luap99 should this be tagged for updating the rest of the repos?

@edsantiago edsantiago merged commit d8ee5ce into containers:main Oct 10, 2024
41 checks passed
@Luap99 Luap99 deleted the win-zstd branch October 10, 2024 18:01
@Luap99
Copy link
Member Author

Luap99 commented Oct 10, 2024

Yes sure let's give it go elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants