-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] Packit: Enable sidetags for bodhi updates #23927
Conversation
Packit now has sidetag support for adding multiple builds into a single bodhi update. Since we release c/ccommon, skopeo, buildah and podman often almoost simultaneously, we should release them to Fedora in a single bodhi update using sidetags so all builds can be tested together. Signed-off-by: Lokesh Mandvekar <[email protected]>
ELN is kind of a midway between Fedora and RHEL, so it's best to mention ELN jobs separately. This will also allow reusing fedora targets using YAML anchors for TMT tests. Signed-off-by: Lokesh Mandvekar <[email protected]>
@containers/podman-maintainers PTAL . These 3 PRs as well as this very PR should be merged together (IOW, no releases in between) and cherrypicked to the release branches relevant to Fedora. |
Do we actually want buildah skopeo podman all in one update? All the patch versions are released on their own timing so if I understand the packit docs correctly you then have to manually trigger the bodhi updates for each of the patch releases? I guess overall this make sense, i.e. we have important c-common config files in the rpm so shipping all of them at once ensure configs and docs match all our tools and allow for better testing but I am not sure if the patch (z) versions causes more work on your end. |
Given we often release everything together except some of the z-ones, let's give this way a shot.
We shouldn't need manual bodhi updates. Instead we'll need a human to run
Let's see what the experience is like. Would also be a good datapoint for the packit devs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick v5.2 |
@lsm5: #23927 failed to apply on top of branch "v5.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Packit now has sidetag support for adding multiple builds into a single bodhi update.
Since we release c/ccommon, skopeo, buildah and podman often almoost simultaneously, we should release them to Fedora in a single bodhi update using sidetags so all builds can be tested together.
Does this PR introduce a user-facing change?