Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the parameters of 'images.load' and 'login' methods #434

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Extend the parameters of 'images.load' and 'login' methods #434

merged 2 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Add missing parameters for login method 

    - Handle the URL scheme based on TLS
- Since the 'auth' argument is not well documented in the podman
  swagger it will follow the same here until the swagger is better
  documented

Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs @inknos
    milanbalazs authored and inknos committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    46d321f View commit details
    Browse the repository at this point in the history

  2. Add 'file_path' option for images.load method. 

    - Add tests for images.load
- Add validation of arguments via exceptions
- Split the load function so it can raise but can also keep the retun
  type without yielding

Signed-off-by: Milan Balazs <[email protected]>
    @milanbalazs @inknos
    milanbalazs authored and inknos committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    61cb845 View commit details
    Browse the repository at this point in the history