Extend the parameters of 'images.load' and 'login' methods #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle the URL scheme based on TLS - Since the 'auth' argument is not well documented in the podman swagger it will follow the same here until the swagger is better documented Signed-off-by: Milan Balazs <[email protected]>
- Add tests for images.load - Add validation of arguments via exceptions - Split the load function so it can raise but can also keep the retun type without yielding Signed-off-by: Milan Balazs <[email protected]>
|
/lgtm |
inknos
approved these changes
Sep 26, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, milanbalazs, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parameters of login method based on SystemAuth docs:
The new parameter of images.load method:
Fix for: