Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: use docker compose v2 #1034

Merged

Conversation

taylormadore
Copy link
Contributor

@taylormadore taylormadore commented Sep 9, 2024

Docker compose v1 has been deprecated and has been removed from Github actions runner images. Use v2 instead.

See actions/runner-images#9692 and https://docs.docker.com/compose/migrate/ for more information.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • New code has type annotations
  • OpenAPI schema is updated (if applicable)
  • DB schema change has corresponding DB migration (if applicable)
  • README updated (if worker configuration changed, or if applicable)
  • Draft release notes are updated before merging

@taylormadore taylormadore changed the title [DO-NOT-MERGE]: try using docker compose v2 Makefile: use docker compose v2 if available Sep 9, 2024
@taylormadore taylormadore marked this pull request as ready for review September 9, 2024 18:48
Makefile Outdated Show resolved Hide resolved
Docker compose v1 has been deprecated and has been removed from Github
actions runner images

Signed-off-by: Taylor Madore <[email protected]>
The version field in docker-compose.yml is obsolete and is producing a
warning message in docker compose v2.

https://github.com/compose-spec/compose-spec/blob/231b09c30d339e950c0da17fe5bdc793366b8fde/spec.md#version-top-level-element-obsolete

Signed-off-by: Taylor Madore <[email protected]>
@taylormadore taylormadore changed the title Makefile: use docker compose v2 if available Makefile: use docker compose v2 Sep 10, 2024
@taylormadore taylormadore added this pull request to the merge queue Sep 12, 2024
Merged via the queue into containerbuildsystem:master with commit 2e0e7d0 Sep 12, 2024
14 checks passed
@taylormadore taylormadore deleted the docker-compose-v2 branch September 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants