Bump the supported Go version to 1.23 #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes LGTM, but we need something like #1034 to fix the CI |
When basic support for 1.22, i.e. without workspace vendoring was introduced, the docs wasn't updated accordingly, fix that. Fixes: fe18efa Signed-off-by: Erik Skultety <[email protected]>
Quite expectedly the original test value of "1.23.0" has already been reached, so instead of bumping it with each Go version this patch sets the max test Go version to some really big number which we won't hit for a very long while. Signed-off-by: Erik Skultety <[email protected]>
Go 1.23 introduced an opt-in telemetry feature to capture how the toolchains are used [1]. Although it's opt-in today, it may not be the case tomorrow, so explicitly disable telemetry data gathering according to [2]. This is safe to do even before bumping the Go version to 1.23 because the check revolves around the GOTELEMETRY (read-only) env variable which doesn't exist on Go versions prior 1.23. [1] https://tip.golang.org/doc/go1.23#telemetry [2] https://pkg.go.dev/cmd/go@master#hdr-Manage_telemetry_data_and_settings Signed-off-by: Erik Skultety <[email protected]>
Go 1.23 has been released [1], luckily with no real tangible impact, so we not considering the missing 1.22 workspace vendoring support it is safe for us to bump the version. [1] https://tip.golang.org/doc/go1.23 Signed-off-by: Erik Skultety <[email protected]>
The lack of workspace vendoring support from 1.22 remains true even for 1.23. Signed-off-by: Erik Skultety <[email protected]>
taylormadore
approved these changes
Sep 13, 2024
7 tasks
brunoapimentel
approved these changes
Sep 16, 2024
Merged
via the queue into
containerbuildsystem:master
with commit Sep 16, 2024
2e4795a
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.23 was released last month, so bump the max supported version to reflect that. Most notable change from 1.23 regarding Go tooling is the introduction of telemetry data gathering which is opt-in by default. Patch 2 disables telemetry explicitly just in case Go would change stance on this in the future.
The lack of workspace vendoring support from 1.22 still remains true here.
Maintainers will complete the following section