Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - Set traitlets application version #981

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 14, 2024

Fixes #977

Description

This pr set's up the traitlets application to know the current version of conda-store. Setting the version property of a traitlets Application will allow the built in trailtlets '--version' flag to work properly.

For example, running conda-store-server --version now works properly

 $ conda-store-server --version 
2024.11.1
 $ conda-store-worker --version
2024.11.1

ref:
https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L872
https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L200

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Setting the version property of a traitlets Application will allow
the built in trailtlets '--version' flag to work properly.

ref:
  https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L872
  https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L200
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit cf5225a
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/673b1b616ee0b30008f37aff

@soapy1 soapy1 added needs: review 👀 area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Nov 14, 2024
@soapy1 soapy1 requested a review from trallard November 14, 2024 19:28
@soapy1
Copy link
Contributor Author

soapy1 commented Nov 14, 2024

The Build and maybe upload PyPI package /... is currently a little broken, but fixed in this pr . Will rebase this pr to pick up the fix once #983 is merged

@trallard trallard changed the title Set traitlets application version DEV - Set traitlets application version Nov 18, 2024
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this LGTM 🚀 will approve and wait for the CI to complete.

@trallard trallard merged commit 3df36fa into conda-incubator:main Nov 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - conda-store-server --version does not work
2 participants