Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - conda-store-server --version does not work #977

Closed
soapy1 opened this issue Nov 12, 2024 · 2 comments · Fixed by #981
Closed

[BUG] - conda-store-server --version does not work #977

soapy1 opened this issue Nov 12, 2024 · 2 comments · Fixed by #981
Labels
type: bug 🐛 Something isn't working

Comments

@soapy1
Copy link
Contributor

soapy1 commented Nov 12, 2024

Describe the bug

Running the command conda-store-server --version prints 0.0.

Expected behavior

conda-store-server --version should output the version number of the package. For example

$ conda-store-server --version
2024.11.1

How to Reproduce the problem?

To reproduce, follow the steps

$ conda create -n test-env conda python
...

$ conda activate test-env

$ pip install conda-store-server
...

$ conda-store-server --version
0.0
@soapy1 soapy1 added the type: bug 🐛 Something isn't working label Nov 12, 2024
@trallard
Copy link
Collaborator

This is expected to a certain point as conda-store-server does not have a CLI per se but uses traitlets to parse and set app configurations from the command line or a config file.
We could technically add a --version flag, as we do for --standalone, but I don't think this is needed.

@soapy1
Copy link
Contributor Author

soapy1 commented Nov 14, 2024

Ahh, I see makes sense that it's a traitlets thing. I took a little peak at the traitlets code and it looks like it does provide the --version flag already, and it's populated by the version property on the Application class.

So, should be fixed by #981

@trallard trallard moved this from New 🚦 to In Progress 🏗 in conda-store 🐍 Nov 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏗 to Done 💪🏾 in conda-store 🐍 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: Done 💪🏾
Development

Successfully merging a pull request may close this issue.

2 participants