Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: rerender #289

Merged

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #288.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #288

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor Author

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub actions workflow below for more details. You can also ping conda-forge/core for further assistance or you can try rerendering locally.

The following suggestions might help debug any issues:

  • Is the recipe/{meta.yaml,recipe.yaml} file valid?
  • If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
  • Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11284220361.

Now that the CUDA 12.0 migrator is closed, the vendored migrator
included here needs some updates to reflect CUDA 12.0's inclusion in the
global pinnings.
@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@conda-forge-admin conda-forge-admin marked this pull request as ready for review October 11, 2024 00:59
@@ -66,16 +66,8 @@ __migrator:
- 11.1 # [(linux64 or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 11.2 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 11.8 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.0 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The essential bit of the re-rendering error is...

  File "/opt/conda/envs/cf-feedstock-ops/lib/python3.11/site-packages/conda_smithy/variant_algebra.py", line 114, in variant_key_set_union
    return sorted(out_v, key=partial(_version_order, ordering=ordering))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/cf-feedstock-ops/lib/python3.11/site-packages/conda_smithy/variant_algebra.py", line 65, in _version_order
    return ordering.index(v)
           ^^^^^^^^^^^^^^^^^
ValueError: '12.0' is not in list

This is coming up because we closed out the CUDA 12.0 migrator somewhat recently ( conda-forge/conda-forge-pinning-feedstock#6263 )

The feedstock here still uses a vendored migrator for adding CUDA 12.x latest (currently 12.6). To keep this working, updated the cuda_compiler_version's ordering here to include 12.0, which fixes the re-rendering error

So we can continue to use this migrator for CUDA 12.x versions and re-render without further issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, thanks for looking into this for me, John!

@jakirkham
Copy link
Member

As nothing has fundamentally changed about the recipe build, just CI infrastructure (and the migrator fix above), will leave the build/number alone

Adding automerge so future PRs are able to re-render with ease

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

jakirkham commented Oct 11, 2024

One of the Windows builds ran out of disk space while creating the host environment

There were a few warnings that led up to it

##[warning]Free disk space on D:\ is lower than 5%; Currently used: 99.69%
##[warning]Free disk space on D:\ is lower than 5%; Currently used: 99.69%
##[warning]Free disk space on D:\ is lower than 5%; Currently used: 99.69%
##[warning]Free disk space on D:\ is lower than 5%; Currently used: 99.69%
##[warning]Free disk space on D:\ is lower than 5%; Currently used: 99.69%

Here is the actual error:

ERROR conda.core.link:_execute(950): An error occurred while installing package 'conda-forge::python-3.11.10-hce54a09_2_cpython'.
Executing transaction: ...working... done
Rolling back transaction: ...working... done
Traceback (most recent call last):
  File "C:\Miniforge\Scripts\conda-build-script.py", line 10, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "C:\Miniforge\Lib\site-packages\conda_build\cli\main_build.py", line 589, in execute
    api.build(
  File "C:\Miniforge\Lib\site-packages\conda_build\api.py", line 209, in build
    return build_tree(
           ^^^^^^^^^^^
  File "C:\Miniforge\Lib\site-packages\conda_build\build.py", line 3655, in build_tree
    packages_from_this = build(
                         ^^^^^^
  File "C:\Miniforge\Lib\site-packages\conda_build\build.py", line 2701, in build
    environ.create_env(
  File "C:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1050, in create_env
    _execute_actions(prefix, precs)
  File "C:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1340, in _execute_actions
    unlink_link_transaction.execute()
  File "C:\Miniforge\Lib\site-packages\conda\core\link.py", line 354, in execute
    self._execute(
  File "C:\Miniforge\Lib\site-packages\conda\core\link.py", line 970, in _execute
    raise CondaMultiError(
conda.CondaMultiError: [Errno 28] No space left on device
()

Similar warnings are showing up for all of the CI builds (Windows & Linux)

Went ahead and restarted so we can fix the issue this PR was created for. We can follow up on this other item in a new issue

Edit: Filed as issue ( #290 )

@github-actions github-actions bot merged commit 5390de1 into conda-forge:main Oct 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin , please re-render
3 participants