Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access requests #5039

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Access requests #5039

merged 10 commits into from
Mar 14, 2024

Conversation

ruggi
Copy link
Contributor

@ruggi ruggi commented Mar 13, 2024

Fix #5038

Problem:

We need a way to create and update project access requests.

Fix:

  • Added a new table, project_access_request which holds the requests. They are unique per user, per project, and can be in either of three states: pending, accepted, or rejected.
  • Added logic to create a new access request on a project (for which the user is not the owner), as pending
  • Added logic to update an existing access request on an owned project
  • Added three routes for the operations above (CRU)
  • Added tests for the DB operations - I did not add the tests for the routes themselves, but the meat should be fairly solid
  • Requests are addressed via their random token, so not to expose incremental ids, etc etc

Notes

  • I'm keeping things deliberately simple here, in terms of functionality (e.g. no re-issuing of a request, etc.) because we don't have the full functional picture complete yet, but this should be a good-enough foundation.
  • Moreover this is not taking any perms actions per se, as this will need to be integrated with Collaborative projects #5033 whenever that gets merged, but it can be easily done separately so we keep things small and simple.

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Try me

Copy link

relativeci bot commented Mar 13, 2024

Job #10999: Bundle Size — 61.89MiB (~-0.01%).

22f001d(current) vs 2296c28 master#10997(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #10999
     Baseline
Job #10997
Regression  Initial JS 45.2MiB(~+0.01%) 45.2MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 20.27% 20.89%
No change  Chunks 36 36
No change  Assets 40 40
No change  Modules 4369 4369
No change  Duplicate Modules 508 508
No change  Duplicate Code 30.67% 30.67%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10999
     Baseline
Job #10997
Regression  JS 61.88MiB (~+0.01%) 61.88MiB
Improvement  HTML 12.72KiB (-0.39%) 12.77KiB

View job #10999 reportView feat/project-access-request branch activityView project dashboard

Copy link
Contributor

Performance test results:

@liady liady mentioned this pull request Mar 14, 2024
@ruggi ruggi merged commit ee4e4bc into master Mar 14, 2024
14 of 16 checks passed
@ruggi ruggi deleted the feat/project-access-request branch March 14, 2024 10:37
liady added a commit that referenced this pull request Mar 14, 2024
This PR adds the ability to:
* Define a project as collaborative
* Ask for access for this project
* Grant access requests

This builds on #5039 .

The flow (with temp UI):

<video src="https://github.com/concrete-utopia/utopia/assets/7003853/14ba3484-0215-4329-9df4-441f4269f7c3" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial setup for access requests
3 participants