Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collaborative projects #5033

Merged
merged 63 commits into from
Mar 14, 2024
Merged

Collaborative projects #5033

merged 63 commits into from
Mar 14, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Mar 13, 2024 •
edited
Loading

This PR adds the ability to:

  • Define a project as collaborative
  • Ask for access for this project
  • Grant access requests

This builds on #5039 .

The flow (with temp UI):

Monosnap.screencast.2024-03-14.02-14-37.mp4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Try me

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 13, 2024 •
edited
Loading

Job #11035: Bundle Size — 63.2MiB (+2.11%).

ad784ad(current) vs 2296c28 master#11031(baseline)

Warning

Bundle contains 58 duplicate packages – View duplicate packages

Bundle metrics  Change 7 changes Regression 3 regressions
                 Current
Job #11035		      Baseline
Job #11031
Regression  Initial JS 50.38MiB(+11.46%) 45.21MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 48.91% 21.38%
Change  Chunks 40(+11.11%) 36
Change  Assets 44(+10%) 40
Change  Modules 4467(+2.22%) 4370
Regression  Duplicate Modules 605(+19.09%) 508
Regression  Duplicate Code 31.96%(+4.21%) 30.67%
No change  Packages 467 467
No change  Duplicate Packages 58 58
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
Job #11035		      Baseline
Job #11031
Regression  JS 63.19MiB (+2.11%) 61.88MiB
Regression  HTML 14.15KiB (+10.76%) 12.77KiB

View job #11035 report View feat/collaborative-project branch activity View project dashboard

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Performance test results:

@liady liady marked this pull request as ready for review March 13, 2024 16:03
@liady liady changed the title Collaborative projects Collaborative projects infra Mar 13, 2024
@liady liady requested review from Rheeseyb, ruggi and gbalint March 13, 2024 16:23
@ruggi
Copy link
Contributor

ruggi commented Mar 14, 2024

@liady I added tests and did actual lazy loading of access requests in here c3ee65a (#5033)

ruggi
ruggi reviewed Mar 14, 2024
View reviewed changes
utopia-remix/app/types.ts
u: unknown,
): u is ProjectAccessRequestWithUserDetails {
const maybe = u as ProjectAccessRequestWithUserDetails
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I went a little overboard with this, but it feels good enough?

@liady liady mentioned this pull request Mar 14, 2024
Merged
@liady liady merged commit 5fbf3f0 into master Mar 14, 2024
14 of 16 checks passed
@liady liady deleted the feat/collaborative-project branch March 14, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruggi ruggi ruggi approved these changes

@Rheeseyb Rheeseyb Rheeseyb approved these changes

@seanparsons seanparsons seanparsons approved these changes

@gbalint gbalint Awaiting requested review from gbalint

@balazsbajorics balazsbajorics Awaiting requested review from balazsbajorics

@bkrmendy bkrmendy Awaiting requested review from bkrmendy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liady @ruggi @seanparsons @Rheeseyb @balazsbajorics