COMCL-770: Fix Line Item Creations

[shahrukh-compuco]

Overview

This pr fixes the creation of line item that gets created without price field values as with newer civicrm version it is mandatory for a line items to have price field values.

Technical Details

This pr adds a post hook that runs every time a line item is created without price field values and it updates the line item with price field value from default price set(the price set by the name of default_contribution_amount), this price set is created with civicrm installation. Secondly this pr also adds an upgrader which will fill price field values for existing line items.

[jamienovick]

Can you clarify what do we mean by "default" here? @shahrukh-compuco

[shahrukh-compuco]

Can you clarify what do we mean by "default" here? @shahrukh-compuco

done

[jamienovick]

Thanks. Are we sure that all clients will have this price set? Do you know from which version of civicrm it gets added/installed? @shahrukh-compuco

[shahrukh-compuco]

Thanks. Are we sure that all clients will have this price set? Do you know from which version of civicrm it gets added/installed? @shahrukh-compuco

@jamienovick it is from this commit compucorp/civicrm-core@6a48803 which I think was in civicrm 4.3 and it is a reserved price set which means it can only be deleted through a direct query in database so imo it should be there for each client db

[jamienovick]

Thanks. Are we sure that all clients will have this price set? Do you know from which version of civicrm it gets added/installed? @shahrukh-compuco

@jamienovick it is from this commit compucorp/civicrm-core@6a48803 which I think was in civicrm 4.3 and it is a reserved price set which means it can only be deleted through a direct query in database so imo it should be there for each client db

Great perfect thanks