COMCL-770: Fix line item creations

CRM/Financeextras/Upgrader.php

@@ -162,4 +162,30 @@ public function upgrade_1002() {
     return TRUE;
   }
 
+  /**
+   * This upgrade updates line items that have empty price field values
+   */
+  public function upgrade_1003() {
+    $this->ctx->log->info('Applying update 1003');
+
+    try {
+      $priceSetId        = \CRM_Core_DAO::getFieldValue('CRM_Price_DAO_PriceSet', 'default_contribution_amount', 'id', 'name');
+      $priceSet          = current(\CRM_Price_BAO_PriceSet::getSetDetail($priceSetId));
+      $priceFieldID      = \CRM_Price_BAO_PriceSet::getOnlyPriceFieldID($priceSet);
+      $priceFieldValueID = \CRM_Price_BAO_PriceSet::getOnlyPriceFieldValueID($priceSet);
+
+      \Civi\Api4\LineItem::update(false)
+        ->addValue('price_field_id', $priceFieldID)
+        ->addValue('price_field_value_id', $priceFieldValueID)
+        ->addClause('OR', ['price_field_id', 'IS NULL'], ['price_field_value_id', 'IS NULL'])
+        ->execute();
+
+      return true;
+    } catch (\Throwable $e) {
+      $this->ctx->log->info($e->getMessage());
+
+      return false;
+    }
+  }
+
 }

Civi/Financeextras/Hook/Post/UpdateLineItemPriceFieldValues.php

@@ -0,0 +1,49 @@
+<?php
+
+namespace Civi\Financeextras\Hook\Post;
+
+class UpdateLineItemPriceFieldValues {
+
+  public function __construct(
+    private string $op,
+    private string $objectName,
+    private int $objectId,
+    private $objectRef,
+  ) {
+  }
+
+  public function run() {
+    $this->updatePriceFieldValues();
+  }
+
+  private function updatePriceFieldValues(): void
+  {
+    try {
+      $record = (array) $this->objectRef;
+
+      if ($this->objectName !== 'LineItem' || !in_array($this->op, ['create', 'edit'])
+        || ((!in_array($record['price_field_id'], [NULL, 'null'])) && (!in_array($record['price_field_value_id'], [NULL, 'null'])))) {
+        return;
+      }
+
+      $priceSetId        = \CRM_Core_DAO::getFieldValue('CRM_Price_DAO_PriceSet', 'default_contribution_amount', 'id', 'name');
+      $priceSet          = current(\CRM_Price_BAO_PriceSet::getSetDetail($priceSetId));
+      $priceFieldID      = \CRM_Price_BAO_PriceSet::getOnlyPriceFieldID($priceSet);
+      $priceFieldValueID = \CRM_Price_BAO_PriceSet::getOnlyPriceFieldValueID($priceSet);
+
+      $lineItem = \Civi\Api4\LineItem::update(FALSE);
+
+      if (in_array($record['price_field_id'], [NULL, 'null'])) {
+        $lineItem->addValue('price_field_id', $priceFieldID);
+      }
+      if (in_array($record['price_field_value_id'], [NULL, 'null'])) {
+        $lineItem->addValue('price_field_value_id', $priceFieldValueID);
+      }
+
+      $lineItem->addWhere('id', '=', $this->objectId)->execute();
+
+    } catch (\Throwable $e) {
+    }
+  }
+
+}

financeextras.php

@@ -125,6 +125,7 @@ function financeextras_civicrm_post($op, $objectName, $objectId, &$objectRef) {
 
     (new \Civi\Financeextras\Hook\Post\UpdateContributionExchangeRate($objectId))->run();
   }
+  (new \Civi\Financeextras\Hook\Post\UpdateLineItemPriceFieldValues($op, $objectName, $objectId, $objectRef))->run();
 }
 
 /**