-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRYD-1399: RestrictedMedia #428
base: v8.1-branch
Are you sure you want to change the base?
DRYD-1399: RestrictedMedia #428
Conversation
I deployed CollectionSpace locally with this PR as well as collectionspace/application#301. I verified both
That test failed before I installed the PR so I don't think the PR is responsible. I have not looked into the merge conflicts that GitHub is reporting. @mikejritter will you do that? |
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1399
This adds a new type of Media procedure, RestrictedMedia, which is intended for use in workflows where there may be sensitive media which should not be immediately accessible. Currently it functions the same as the Media service, with the same logic for the Resource, Client, Proxy, and DocumentHandler classes.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
RestrictedMediaResource#createBlob
is deprecated and likely doesn't make sense to carry over to a new service. It seems like the original deprecation (in MediaResource) was just in reference to usingPUT
vsPOST
.I had been considering doing all the Blob handling for RestrictedMedia in the new Resource as well, but I opted to keep this simple for now as getting things setup to access the persistence layer was not as straightforward as I was expecting.
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested with the old PR, not new