Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1399: RestrictedMedia #301

Open
wants to merge 2 commits into
base: v8.1-branch
Choose a base branch
from

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Add a RestrictedMedia procedure
  • Enable restricted media in core and anthro

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1399

This adds a new type of Media procedure, RestrictedMedia, which is intended for use in workflows where there may be sensitive media which should not be immediately accessible. Currently it has the same definition as the Media procedure, including the blob subresource.

How should this be tested? Do these changes have associated tests?

  • Re-build and deploy collectionspace
  • Start collectionspace
  • Test that the restrictedmedia service is accessible, e.g.
curl -u '[email protected]:Administrator' http://localhost:8180/cspace-services/restrictedmedia/

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against the old PR

@mikejritter mikejritter changed the base branch from master to v8.1-branch October 29, 2024 18:34
@axb21
Copy link

axb21 commented Nov 19, 2024

I deployed CollectionSpace locally with this PR as well as collectionspace/services#428. I verified both curl -u '[email protected]:PASSWORD' http://localhost:8180/cspace-services/restrictedmedia/ and curl -u '[email protected]:PASSWORD' http://localhost:8180/cspace-services/restrictedmedia/ return the expected results.

mvn test -fae returns:

Failed tests: 
  TestPermissions.testRoles:54->createUser:269 UnderlyingStorageException:Service layer exception
  TestService.testJSONXMLConversion:138->testJSONXML:235->testJSONXML:224 JSON->XML->JSON round-trip for record type: concept doesn't match original JSON
  TestService.testXMLJSONConversion:86->testXMLJSON:265 Generated JSON for record type: concept doesn't match original JSON
  TestServiceThroughAPI.testGetId:123 null
  TestServiceThroughAPI.testMini:220 expected:<[TEST4]> but was:<[]>

Tests in error: 
  TestAccount.testAccountCreate:76 » UnderlyingStorage Service layer exception
  TestServiceThroughAPI.testObjectsList:148 » UnderlyingStorage Service layer ex...

Tests run: 20, Failures: 5, Errors: 2, Skipped: 0

I don't know if these are newly introduced by this PR or not.

I have not looked into the merge conflicts that GitHub is reporting. @mikejritter will you do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants